Make it possible to develop without copying library to node_modules #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
approved these changes
Sep 19, 2018
osdnk
commented
Sep 20, 2018
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| #import <React/RCTLog.h> | |||
| #import <React/RCTUIManager.h> | |||
| #import "RCTComponentData.h" | |||
| #import "React/RCTComponentData.h" | |||
There was a problem hiding this comment.
This appears not ot change anything, but make example compilable
osdnk
commented
Sep 20, 2018
Example/package.json
Outdated
| "test": "jest", | ||
| "postinstall": | ||
| "rm -rf node_modules/react-native-reanimated/{.git,node_modules,Example}" | ||
| "postinstall": "mkdir node_modules/react-native-reanimated2 && ln -s ../../../android node_modules/react-native-reanimated2/android && ln -s ../../../package.json node_modules/react-native-reanimated2/package.json" |
There was a problem hiding this comment.
symlinks fron android and package.json are required by android compiler. Didn't manage to do it without it
osdnk
commented
Sep 20, 2018
Example/android/app/build.gradle
Outdated
| @@ -137,7 +137,7 @@ android { | |||
| } | |||
|
|
|||
| dependencies { | |||
| compile project(':react-native-reanimated') | |||
| compile project(':react-native-reanimated2') | |||
There was a problem hiding this comment.
in order to avoid namespace conflict
kmagiera
approved these changes
Sep 25, 2018
kmagiera
pushed a commit
to software-mansion/react-native-gesture-handler
that referenced
this pull request
Dec 13, 2018
janicduplessis
pushed a commit
to janicduplessis/react-native-gesture-handler
that referenced
this pull request
Feb 16, 2020
MatiPl01
added a commit
that referenced
this pull request
Jan 21, 2025
* Fix some Android issues in the example app * Some more adjustments * Move css example app to css-example, restore fabric-example
MatiPl01
added a commit
that referenced
this pull request
Jan 21, 2025
* Fix some Android issues in the example app * Some more adjustments * Move css example app to css-example, restore fabric-example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by: https://github.com/callstack/react-native-paper/tree/master/example
and https://blog.callstack.io/adding-an-example-app-to-your-react-native-library-d23b9741a19c
cc: @satya164 😻, thanks!