[General] Cleanup duplicated callbacks #3885
Open
+110
−163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bert
reviewed
Dec 18, 2025
Comment on lines
+244
to
+246
| shouldUseReanimatedDetector | ||
| ? reanimatedHandlers.onGestureHandlerReanimatedEvent | ||
| : undefined |
Contributor
There was a problem hiding this comment.
So this is the only callback used by the native side, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the optimization PRs, the event handlers for js/ui thread were collapsed to a single function, but throughout the code, those are still being passed like before those changes - as three separate functions. Those are the same exact functions but under different names. This PR changes that, so that only one function is passed. Ultimately, this function still ends up in three different events, but the split now happens at the leafs instead of the root.
Test plan
Gestures should still work