Skip to content

Fix grabbing delegate in setPressed #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2025
Merged

Fix grabbing delegate in setPressed #3742

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94ae6e9
fix (potentially unsafe)
akwasniewski Oct 13, 2025
86af46a
safe
akwasniewski Oct 13, 2025
a6664db
Merge branch 'main' into @akwasniewski/android-unresponsive-pressable
akwasniewski Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions ...oid/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerButtonViewManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,11 @@ class RNGestureHandlerButtonViewManager :
val isResponder = tryGrabbingResponder()
if (isResponder) {
isTouched = true
// when setPressed(true) is called before canBegin it will not call super.setPressed
// in this case we call it here
setPressed(true)
}

return isResponder
}

Expand Down Expand Up @@ -515,16 +519,6 @@ class RNGestureHandlerButtonViewManager :
}

override fun setPressed(pressed: Boolean) {
// there is a possibility of this method being called before NativeViewGestureHandler has
// opportunity to call canStart, in that case we need to grab responder in case the gesture
// will activate
// when canStart is called eventually, tryGrabbingResponder will return true if the button
// already is a responder
if (pressed) {
if (tryGrabbingResponder()) {
soundResponder = this
}
}
// button can be pressed alongside other button if both are non-exclusive and it doesn't have
// any pressed children (to prevent pressing the parent when children is pressed).
val canBePressedAlongsideOther = !exclusive && touchResponder?.exclusive != true && !isChildTouched()
Expand All @@ -535,6 +529,7 @@ class RNGestureHandlerButtonViewManager :
isTouched = pressed
super.setPressed(pressed)
}

if (!pressed && touchResponder === this) {
// if the responder is no longer pressed we release button responder
isTouched = false
Expand Down