Add Pod Spec [BREAKING] #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Tested this and appears to be working. This is a breaking change for podspec consumers and will require them to update podspec path after upgrade. I added a comment re that to your PR description and will make sure one is included in release notes too. Thanks! |
kmagiera
approved these changes
Dec 4, 2018
janicduplessis
pushed a commit
to janicduplessis/react-native-gesture-handler
that referenced
this pull request
Feb 16, 2020
The other PR software-mansion#209 use use different project name than ios/RNGestureHandler.podspec, this might create some conflict. Also podspec file need to be included with `package.json`, otherwise it will be ignored during `npm install`. **[BREAKING]** Podspec location has been changed from `./ios/RNGestureHandler.podspec` to `./RNGestureHandler.podspec`. The previous consumers of the podspec should update their podfile to reflect that change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other PR #209 use use different project name than ios/RNGestureHandler.podspec, this might create some conflict.
Also podspec file need to be included with
package.json, otherwise it will be ignored duringnpm install.[BREAKING] Podspec location has been changed from
./ios/RNGestureHandler.podspecto./RNGestureHandler.podspec. The previous consumers of the podspec should update their podfile to reflect that change