Remove view flattening error for Text component

android/src/main/jni/cpp-adapter.cpp

@@ -1,15 +1,17 @@
 #include <jni.h>
 #include <jsi/jsi.h>
 
+#include <react/renderer/components/text/ParagraphShadowNode.h>
+#include <react/renderer/components/text/TextShadowNode.h>
 #include <react/renderer/uimanager/primitives.h>
 
 using namespace facebook;
 using namespace react;
 
 void decorateRuntime(jsi::Runtime &runtime) {
-    auto isFormsStackingContext = jsi::Function::createFromHostFunction(
+    auto isViewFlatteningDisabled = jsi::Function::createFromHostFunction(
             runtime,
-            jsi::PropNameID::forAscii(runtime, "isFormsStackingContext"),
+            jsi::PropNameID::forAscii(runtime, "isViewFlatteningDisabled"),
             1,
             [](jsi::Runtime &runtime,
                const jsi::Value &thisValue,
@@ -20,21 +22,28 @@ void decorateRuntime(jsi::Runtime &runtime) {
                 }
 
                 auto shadowNode = shadowNodeFromValue(runtime, arguments[0]);
-                bool isFormsStackingContext = shadowNode->getTraits().check(ShadowNodeTraits::FormsStackingContext);
+                bool isViewFlatteningDisabled = shadowNode->getTraits().check(
+                        ShadowNodeTraits::FormsStackingContext);
 
-                return jsi::Value(isFormsStackingContext);
+                // This is done using component names instead of type checking because
+                // of duplicate symbols for RN types, which prevent RTTI from working.
+                const char *componentName = shadowNode->getComponentName();
+                bool isTextComponent = strcmp(componentName, "Paragraph") == 0 ||
+                                       strcmp(componentName, "Text") == 0;
+
+                return jsi::Value(isViewFlatteningDisabled || isTextComponent);
             });
     runtime.global().setProperty(
-            runtime, "isFormsStackingContext", std::move(isFormsStackingContext));
+            runtime, "isViewFlatteningDisabled", std::move(isViewFlatteningDisabled));
 }
 
 extern "C" JNIEXPORT void JNICALL
 Java_com_swmansion_gesturehandler_react_RNGestureHandlerModule_decorateRuntime(
-    JNIEnv *env,
-    jobject clazz,
-    jlong jsiPtr) {
-  jsi::Runtime *runtime = reinterpret_cast<jsi::Runtime *>(jsiPtr);
-  if (runtime) {
-    decorateRuntime(*runtime);
-  }
+        JNIEnv *env,
+        jobject clazz,
+        jlong jsiPtr) {
+    jsi::Runtime *runtime = reinterpret_cast<jsi::Runtime *>(jsiPtr);
+    if (runtime) {
+        decorateRuntime(*runtime);
+    }
 }

apple/RNGestureHandlerModule.mm

@@ -14,6 +14,8 @@
 #import <ReactCommon/CallInvoker.h>
 #import <ReactCommon/RCTTurboModule.h>
 
+#import <react/renderer/components/text/ParagraphShadowNode.h>
+#import <react/renderer/components/text/TextShadowNode.h>
 #import <react/renderer/uimanager/primitives.h>
 #endif // RCT_NEW_ARCH_ENABLED
 
@@ -91,19 +93,29 @@ - (dispatch_queue_t)methodQueue
 #ifdef RCT_NEW_ARCH_ENABLED
 void decorateRuntime(jsi::Runtime &runtime)
 {
-  auto isFormsStackingContext = jsi::Function::createFromHostFunction(
+  auto isViewFlatteningDisabled = jsi::Function::createFromHostFunction(
       runtime,
-      jsi::PropNameID::forAscii(runtime, "isFormsStackingContext"),
+      jsi::PropNameID::forAscii(runtime, "isViewFlatteningDisabled"),
       1,
       [](jsi::Runtime &runtime, const jsi::Value &thisValue, const jsi::Value *arguments, size_t count) -> jsi::Value {
         if (!arguments[0].isObject()) {
           return jsi::Value::null();
         }
         auto shadowNode = shadowNodeFromValue(runtime, arguments[0]);
-        bool isFormsStackingContext = shadowNode->getTraits().check(ShadowNodeTraits::FormsStackingContext);
-        return jsi::Value(isFormsStackingContext);
+
+        if (dynamic_pointer_cast<const ParagraphShadowNode>(shadowNode)) {
+          return jsi::Value(true);
+        }
+
+        if (dynamic_pointer_cast<const TextShadowNode>(shadowNode)) {
+          return jsi::Value(true);
+        }
+
+        bool isViewFlatteningDisabled = shadowNode->getTraits().check(ShadowNodeTraits::FormsStackingContext);
+
+        return jsi::Value(isViewFlatteningDisabled);
       });
-  runtime.global().setProperty(runtime, "isFormsStackingContext", std::move(isFormsStackingContext));
+  runtime.global().setProperty(runtime, "isViewFlatteningDisabled", std::move(isViewFlatteningDisabled));
 }
 #endif // RCT_NEW_ARCH_ENABLED
 

src/handlers/gestures/GestureDetector/useViewRefHandler.ts

@@ -6,7 +6,7 @@ import React, { useCallback } from 'react';
 import findNodeHandle from '../../../findNodeHandle';
 
 declare const global: {
-  isFormsStackingContext: (node: unknown) => boolean | null; // JSI function
+  isViewFlatteningDisabled: (node: unknown) => boolean | null; // JSI function
 };
 
 // Ref handler for the Wrap component attached under the GestureDetector.
@@ -35,9 +35,9 @@ export function useViewRefHandler(
         updateAttachedGestures(true);
       }
 
-      if (__DEV__ && isFabric() && global.isFormsStackingContext) {
+      if (__DEV__ && isFabric() && global.isViewFlatteningDisabled) {
         const node = getShadowNodeFromRef(ref);
-        if (global.isFormsStackingContext(node) === false) {
+        if (global.isViewFlatteningDisabled(node) === false) {
           console.error(
             tagMessage(
               'GestureDetector has received a child that may get view-flattened. ' +