Make stylusData
property of the GestureUpdateEvent
optional
#3270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Idk what's your policy on types & whether the type
stylusData: StylusData | undefined
type is intended in this form or not,but currently when creating event of type
GestureUpdateEvent<PanGestureHandlerEventPayload>
user is forced to specifystylusData
even if there is none - in such casestylusData: undefined
must be passed; the prop can not be just simply omitted.I'm humbly suggesting that you consider relaxing these types a bit to
stylusData?: StylusData | undefined
, so that itdoes not have to be always specified.
Context: this is just quality of life improvement IMO, not crucial. I've stubmled upon this when I've bumped version of
gesture-handler
inreact-native-screens
(link)Test plan
N/A, every thing should work as before