Skip to content

[Web] Remove unnecessary overrides #3257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2024
Merged

[Web] Remove unnecessary overrides #3257

merged 1 commit into from
Dec 4, 2024

Conversation

m-bert
Copy link
Contributor

@m-bert m-bert commented Dec 4, 2024

Description

This PR removes unnecessary overriden functions

Test plan

Run example app

@m-bert m-bert changed the title [web] Remove unnecessary overrides [Web] Remove unnecessary overrides Dec 4, 2024
@m-bert m-bert requested review from j-piasecki and latekvo December 4, 2024 11:18
@j-piasecki
Copy link
Member

Can't this one target main branch?

@m-bert
Copy link
Contributor Author

m-bert commented Dec 4, 2024

@j-piasecki Yes it can, I've targeted next because earlier on I was working on some GH3 part and I remembered that we wanted to clean some things up in 3, hence I did it this way 😅

@m-bert m-bert changed the base branch from next to main December 4, 2024 11:38
@m-bert m-bert merged commit 3d137ff into main Dec 4, 2024
1 check passed
@m-bert m-bert deleted the @mbert/web-refactor-1 branch December 4, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-piasecki j-piasecki j-piasecki approved these changes

@latekvo latekvo Awaiting requested review from latekvo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-bert @j-piasecki