-
-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs page for the new ReanimatedDrawerLayout
component
#3188
base: main
Are you sure you want to change the base?
Add docs page for the new ReanimatedDrawerLayout
component
#3188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much for now as these comments may change a bit 😅
a function which is called when drawer is moving or animating. | ||
Provided with a `progress` SharedValue parameter that indicates the progress of drawer opening/closing. Equals `0` when drawer is `closed` and `1` when `open`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here, what equals 0
?
a renderer function for the drawer component. | ||
Provided with a `progress` SharedValue parameter that indicates the progress of drawer opening/closing. Equals `0` when drawer is `closed` and `1` when `open`. | ||
This can be used by the drawer component to animated its children while the drawer is opening or closing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, I'd probably merge first two sentences as the second one sounds a bit odd on its own. Beside that
Equals `0` when drawer is `closed` and `1` when `open`.
What equals 0
? A function? And let's stay consistent, if we use closed
, then we should also use opened
.
Either way, I believe it can be rewritten is a better way 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, does something like this work better?
a renderer function for the drawer component, provided with a
progress
SharedValue parameter that indicates the progress of drawer opening/closing animation.
progress
equals0
when the drawer isclosed
and1
when the drawer isopened
.progress
can be used by the drawer component to animated its children while the drawer is opening or closing.
Inspired by the progress
description used in the reanimated_swipeable.md
docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is definitely better 😅 What about:
a renderer function for the drawer component, provided with a progress
parameter.
progress
-SharedValue
that indicates the progress of drawer opening/closing animation.- equals
0
when thedrawer
is closed and1
when thedrawer
is opened - can be used by the
drawer
component to animated its children while thedrawer
is opening or closing
- equals
Description
This PR adds documentation page for the new
ReanimatedDrawerLayout
component.wait for #3146
Test plan
ReanimatedDrawerLayout