Fix Pressable
styling by removing unnecessary wrapping View
#3087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes outer
View
fromPressable
which was previously used for applying props, which were otherwise unavailable onNativeButton
.All such props have been either manually implemented, or have turned out to be available to use directly in
NativeButton
, so the outerView
can be safely removed.closes #3085
Test plan
EmptyExample
EmptyExample
Verifying accessibility
[iOS]
Turn onsmart inverted colors mode
[Android]
Turn ontalkback
EmptyExample
EmptyExample
[iOS]
See how theNested box model styling
section has regular colors[Android]
Press theNested box model styling
and hear how it saysAccessibility is working
note:
Most accessibility styles are not implemented on
web
, but you can verify that accessibility is working on web by inspecting thePressable
and looking forrole="button"
prop in the HTML, it is an accessibility prop that i found to be working on web.Code
Collapsed code