[Web] Fix onStart firing on Pan with activateAfterLongPress when gesture is disabled while being pressed down.

[latekvo]

Description

Pan gesture allows for use of activateAfterLongPress modifier, which allows it to be activated after holding down the gesture down for a specified amount of time.

This modifier uses setTimeout underneath, which was not properly cleared when the gesture was disabled while being pressed down.

Closes: #3074

Test plan

• run the attached code
• when the button is clicked 2 times, nothing happens
• without this PR, clicking the button 2 times results in onStart firing on the Pan gesture due to lack of timeout clearing

Attached code

• make sure to have @shopify/flash-list installed

Collapsed code

import React from 'react';
import { Button, View } from 'react-native';
import { FlashList } from '@shopify/flash-list';
import { Gesture, GestureDetector } from 'react-native-gesture-handler';

export default function HomeScreen() {
  const [enabled, setEnabled] = React.useState(true);
  const data = [0];

  const panGesture = Gesture.Pan()
    .enabled(enabled)
    .activateAfterLongPress(750)
    .onStart(() => {
      console.warn('pan triggered');
    });

  return (
    <GestureDetector gesture={panGesture}>
      <FlashList
        data={data}
        ListHeaderComponent={
          <Button
            title={enabled ? 'Disable Gestures' : 'Enable Gestures'}
            onPress={() => {
              setEnabled((prev) => !prev);
            }}
          />
        }
        renderItem={() => {
          return (
            <View
              style={{
                height: 70,
                backgroundColor: 'tomato',
              }}
            />
          );
        }}
      />
    </GestureDetector>
  );
}

Results

Collapsed results recordings

Before

Screen.Recording.2024-08-29.at.11.10.22.mov

Fixed

Screen.Recording.2024-08-29.at.11.09.38.mov

Important:

As far as I see, all the other calls to this.clearActivationTimeout() can be activated individually, and none of them are redundant.

[frankcalise]

Works perfectly! Tested a patch on 2.18.1, thank you!