Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've noticed that our
e2e
tests don't work anymore. Well.. they (almost) did, I've just wrongly assumed that you can open web on standard metro port8081
like in our example app. The only thing that required fix was default port number.Nevertheless, this made me look into our
e2e
app and it resulted in few changes:.gitignore
yarn start
- now this script opensweb
bu default. Also it starts expo without opening browseryarn test
- it is easier to use this instead ofnpx playwright test
19006
Warning
Previously tests on
webkit
(i.e.safari
) didn't work. Now after upgrading browsers they do... but tests onfirefox
fail. From what I've found, it is because for some reason Locator.innerText returns empty string. Adding timeout doesn't fix it, so it doesn't seem like race condition. Maybe it will be fixed with newfirefox
update.Test plan
Go to
e2e/web-tests
and run:yarn start
yarn test