Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright improvements #3065

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Playwright improvements #3065

merged 5 commits into from
Aug 26, 2024

Conversation

m-bert
Copy link
Contributor

@m-bert m-bert commented Aug 23, 2024

Description

I've noticed that our e2e tests don't work anymore. Well.. they (almost) did, I've just wrongly assumed that you can open web on standard metro port 8081 like in our example app. The only thing that required fix was default port number.

Nevertheless, this made me look into our e2e app and it resulted in few changes:

  • Bumped expo version
  • Added .gitignore
  • Changed scripts:
    • yarn start - now this script opens web bu default. Also it starts expo without opening browser
    • yarn test - it is easier to use this instead of npx playwright test
  • Changed default port to 19006

Warning

Previously tests on webkit (i.e. safari) didn't work. Now after upgrading browsers they do... but tests on firefox fail. From what I've found, it is because for some reason Locator.innerText returns empty string. Adding timeout doesn't fix it, so it doesn't seem like race condition. Maybe it will be fixed with new firefox update.

Test plan

Go to e2e/web-tests and run:

  1. yarn start
  2. yarn test

@m-bert m-bert requested a review from j-piasecki August 23, 2024 12:17
Copy link
Member

@j-piasecki j-piasecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to check the firefox again in the near future

@m-bert
Copy link
Contributor Author

m-bert commented Aug 26, 2024

It would be nice to check the firefox again in the near future

True, maybe it will be fixed in newer versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants