Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken image and improve docs #3040

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Fix broken image and improve docs #3040

merged 3 commits into from
Aug 12, 2024

Conversation

shubh73
Copy link
Contributor

@shubh73 shubh73 commented Aug 11, 2024

Description

PR addresses the following issues:

  • Typos and improved docs.
  • Broken image in testimonials.

Test plan

CI passes.

m-bert
m-bert approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@m-bert m-bert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

patrycjakalinska
patrycjakalinska requested changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@patrycjakalinska patrycjakalinska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, only one small change 👍

docs/docs/fundamentals/manual-gestures/index.md Outdated Show resolved Hide resolved
@shubh73 @patrycjakalinska
fix: suggested changes
eeea44b 
Co-authored-by: Patrycja Kalińska <59940332+patrycjakalinska@users.noreply.github.com>
patrycjakalinska
patrycjakalinska approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@patrycjakalinska patrycjakalinska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 🚀

@m-bert m-bert merged commit 78de2c3 into software-mansion:main Aug 12, 2024
1 check passed
@shubh73 shubh73 deleted the fix/improve-docs branch August 12, 2024 11:59
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Sep 23, 2024
Open
@yingbull yingbull mentioned this pull request Sep 28, 2024
Closed
@Adam-1052189 Adam-1052189 mentioned this pull request Sep 28, 2024
Open
@Alaa-1074002 Alaa-1074002 mentioned this pull request Sep 29, 2024
Open
@ColeCoffman ColeCoffman mentioned this pull request Oct 2, 2024
Open
@santiko santiko mentioned this pull request Oct 3, 2024
Open
@Abyss0108 Abyss0108 mentioned this pull request Nov 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-bert m-bert m-bert approved these changes

@patrycjakalinska patrycjakalinska patrycjakalinska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubh73 @patrycjakalinska @m-bert