Skip to content

Fix onPressOut not being triggered #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
latekvo merged 5 commits into from
Jul 8, 2024
Merged

Fix onPressOut not being triggered #2977

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
670fac2
update unusual behaviour's comment
latekvo Jul 3, 2024
caf62e1
fix typo
latekvo Jul 3, 2024
99c82be
fix accidentally commented out code
latekvo Jul 3, 2024
57c1387
fix stuck function styles
latekvo Jul 3, 2024
8f6bdc2
move setState to the far back of the function it's in
latekvo Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/components/Pressable/Pressable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ export default function Pressable(props: PressableProps) {
const pressInHandler = useCallback((event: GestureTouchEvent) => {
props.onPressIn?.(adaptTouchEvent(event));
isPressCallbackEnabled.current = true;
setPressedState(true);
pressDelayTimeoutRef.current = null;
setPressedState(true);
}, []);
const pressOutHandler = useCallback((event: GestureTouchEvent) => {
if (
Expand All @@ -107,7 +107,9 @@ export default function Pressable(props: PressableProps) {
}

if (props.unstable_pressDelay && pressDelayTimeoutRef.current !== null) {
// legacy Pressable behaviour - if pressDelay is set, we want to call onPressIn on touch up
// when delay is preemptively finished by lifting touches,
// we want to immediately activate it's effects - pressInHandler,
// even though we are located at the pressOutHandler
clearTimeout(pressDelayTimeoutRef.current);
pressInHandler(event);
}
Expand Down Expand Up @@ -174,19 +176,19 @@ export default function Pressable(props: PressableProps) {
pressOutHandler(event);
})
.onTouchesCancelled((event) => {
if (handlingOnTouchesDown.current) {
cancelledMidPress.current = true;
onEndHandlingTouchesDown.current = () => pressOutHandler(event);
return;
}

if (
!isPressedDown.current ||
event.allTouches.length > event.changedTouches.length
) {
return;
}

if (handlingOnTouchesDown.current) {
cancelledMidPress.current = true;
onEndHandlingTouchesDown.current = () => pressOutHandler(event);
return;
}

pressOutHandler(event);
}),
[
Expand Down