Fix RNGestureHandlerManager to use explicit imports #1160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I work on RN Core at Facebook, and am encountering a unique problem. I'm trying to refactor
RCTEventDispatcher
, but cannot because of the implicit dependency onRCTEventDispatcher
inRNGestureHandlerManager
. We use rn-gesture-handler internally, and builds for it fail after the refactor.The fix is to explicitly depend on
RCTEventDispatcher
instead of relying on theRCTUIManager -> RCTViewManager -> RCTEventDispatcher
import chain.Test plan
I unfortunately did not test this. I can't get react-native-gesture-handler building locally. I assume that there are CI builds that would fail on a simple compilation error.