Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize color of ripple on Android #58

Closed
brentvatne opened this issue Nov 23, 2017 · 2 comments
Closed

Customize color of ripple on Android #58

brentvatne opened this issue Nov 23, 2017 · 2 comments

Comments

@brentvatne
Copy link
Contributor

For RectButton I believe this is done with underlayColor, but there doesn't seem to be an option for this on BorderlessButton
@gtfargo
Copy link

gtfargo commented Jan 30, 2018 •
edited
Loading

Wanted to note that underlayColor for Android does not seem to be working on <RectButton /> right now.

Just put together a Snack and realized this issue may be caused by setting a backgroundColor on the <RectButton />, though I'm not sure this is intended.

https://snack.expo.io/Bk2OQYRHG

@antsmo
Copy link

antsmo commented Feb 17, 2018

Just wanted to add I'm getting this issue @gtfargo described. I had set the backgroundColor but removing that doesn't help, the ripple is still semi-transparent black

@osdnk osdnk mentioned this issue May 21, 2018
Merged
kmagiera pushed a commit that referenced this issue Dec 6, 2018
@osdnk @kmagiera
Issue #58 - Ripple color button android (#183)
5915c60 
## Motivation 
It is response for issue #58.
Wish to add functionality to select ripple color on Android

## Changes
Colour and props processing in JS.
Add parameter and its handling in Android Core based on https://stackoverflow.com/questions/33061050/how-can-i-modify-ripple-color-when-using-attr-selectableitembackground-as-backg/33085033
Minor stylefixes made automatically
janicduplessis pushed a commit to janicduplessis/react-native-gesture-handler that referenced this issue Feb 16, 2020
@osdnk @janicduplessis
Issue software-mansion#58 - Ripple color button android (software-man…
67fddf6 
…sion#183)

## Motivation 
It is response for issue software-mansion#58.
Wish to add functionality to select ripple color on Android

## Changes
Colour and props processing in JS.
Add parameter and its handling in Android Core based on https://stackoverflow.com/questions/33061050/how-can-i-modify-ripple-color-when-using-attr-selectableitembackground-as-backg/33085033
Minor stylefixes made automatically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brentvatne @gtfargo @antsmo