Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release (1.9.0) breaks build #1235

Closed
alina-beck opened this issue Nov 23, 2020 · 14 comments
Closed

Latest release (1.9.0) breaks build #1235

alina-beck opened this issue Nov 23, 2020 · 14 comments
Labels
Build or config issue This issue is likely related to the reporter's specific project config

Comments

@alina-beck
Copy link

Description

When running npx react-native run-ios the build fails with the following errors:

/Users/xxx/MyApp/node_modules/react-native-gesture-handler/ios/Handlers/RNPanHandler.m:212:18:
error: property 'allowedScrollTypesMask' not found on object of type 'RNBetterPanGestureRecognizer *'
      recognizer.allowedScrollTypesMask = UIScrollTypeMaskAll;
                 ^
/Users/xxx/MyApp/node_modules/react-native-gesture-handler/ios/Handlers/RNPanHandler.m:212:43:
error: use of undeclared identifier 'UIScrollTypeMaskAll'
      recognizer.allowedScrollTypesMask = UIScrollTypeMaskAll;

Downgrading to 1.8.0 solves the issue.

Package versions

  • React: 16.13.1
  • React Native: 0.63.2
  • React Native Gesture Handler: 1.9.0
@jakub-gonet
Copy link
Member

What's your Xcode version? This probably comes from the #1128 PR, which bumped the minimal iOS version to 13 (requiring Xcode 11 to build).

@GZLiew
Copy link

GZLiew commented Nov 24, 2020

yes I can confirm this as well Im running

React: 16.13.1
React Native: 0.63.3
React Native Gesture Handler: 1.9.0
XCode: 11.3.1
iOS simulator device version: 13.3.1

Downgraded back to 1.8.0 immediately works again

@alina-beck
Copy link
Author

Same here: Xcode 11.3.1, simulator iOS version 13.3.

@jakub-gonet jakub-gonet added the Build or config issue This issue is likely related to the reporter's specific project config label Nov 24, 2020
@jakub-gonet
Copy link
Member

Could you try updating Xcode to the 11.4? Looks like allowedScrollTypesMask attribute is supported since 13.4+ iOS SDK which is included in the 11.4 Xcode release.

11.4 was released in March (8 months ago) so I'm closing this as a configuration issue.

@alina-beck
Copy link
Author

Can confirm that this works in Xcode 12.2! 🎉

@hitrik
Copy link

hitrik commented Dec 13, 2020

i comment during development this part at RNPanHandler.m and build works:

  if (@available(iOS 13.4, *)) {
    bool enableTrackpadTwoFingerGesture = [RCTConvert BOOL:config[@"enableTrackpadTwoFingerGesture"]];
    if(enableTrackpadTwoFingerGesture){
      recognizer.allowedScrollTypesMask = UIScrollTypeMaskAll;
    }
}

and my problem with reanimated 2)

@1kjnv
Copy link

1kjnv commented Dec 22, 2020

react-native-gesture-handler@1.8.0 did NOT work for me. However,

react-native-gesture-handler@1.7.0 worked.
XCode: 10.1, Simulator: 12.1
React-native: 0.63.4
React: 16.13.1

@jakub-gonet
Copy link
Member

@AIsokjonov could you please provide more information? What exactly doesn't work for you?

@Dror-Bar
Copy link

Using an older version of Xcode - 11.3.1, I can confirm I had to use version 1.8.0 (not 1.9.0) to avoid this error.

@Stas-Buzunko
Copy link

@jakub-gonet cannot update to 11.4 because latest is 11.3.1 on Mojave :D

@KenCorma
Copy link
Contributor

KenCorma commented Jan 7, 2021

@Stas-Buzunko I am locked to Mojave as well. Just needs to be wrapped in a conditional compile statement.

#1301

@pxl-live
Copy link

Using an older version of Xcode - 11.3.1, I can confirm I had to use version 1.8.0 (not 1.9.0) to avoid this error.

SPENT 5 hours pulling my hair out thinking it was a mistake on my end after updating from react navigation 4 to 5... Im using RN Gesture Handler 1.8.0 and its working. 1.9.0 does not build! using Xcode version 11.3

@jakub-gonet
Copy link
Member

jakub-gonet commented Feb 2, 2021

This should be fixed in #1301 (db78d3c), you can use patch-package to fix it locally until the next RNGH release.

@ghost
Copy link

ghost commented Feb 4, 2021

Screenshot 2021-02-04 at 1 32 00 PM
comment out the line and build succeed.

@software-mansion software-mansion locked as resolved and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Build or config issue This issue is likely related to the reporter's specific project config
Projects
None yet
Development

No branches or pull requests

9 participants