Refactor/remove binaries from repo #749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejmakowski2003
approved these changes
Oct 20, 2025
Collaborator
maciejmakowski2003
left a comment
maciejmakowski2003
left a comment
There was a problem hiding this comment.
lets make RN audio api small package again!!!
poneciak57
requested changes
Oct 20, 2025
Contributor
poneciak57
left a comment
poneciak57
left a comment
There was a problem hiding this comment.
In my view the best way to handle that would be to make it optional similarly to worklets when user can for example download zip with prebuild binaries or use script i dont think that it will work on windows.
poneciak57
requested changes
Oct 22, 2025
packages/react-native-audio-api/scripts/download-prebuilt-binaries.sh
Outdated
Show resolved
Hide resolved
packages/react-native-audio-api/scripts/download-prebuilt-binaries.sh
Outdated
Show resolved
Hide resolved
poneciak57
approved these changes
Oct 23, 2025
michalsek
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Introduced changes
Checklist