Skip to content

Conversation

@mdydek
Copy link
Contributor

@mdydek mdydek commented Oct 7, 2025

Closes #717

⚠️ Breaking changes ⚠️

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web

@mdydek mdydek added the fix label Oct 7, 2025
@maciejmakowski2003
Copy link
Collaborator

I think we should do the same for rest of the callbacks

@mdydek
Copy link
Contributor Author

mdydek commented Oct 7, 2025

@maciejmakowski2003 you mean that leave only clearing callback in host object destructor?

@maciejmakowski2003
Copy link
Collaborator

@maciejmakowski2003 you mean that leave only clearing callback in host object destructor?

exactly

@mdydek mdydek marked this pull request as ready for review October 8, 2025 11:02
@mdydek mdydek merged commit 971a6b4 into main Oct 8, 2025
3 checks passed
@mdydek mdydek deleted the fix/possible-solution-for-error-from-events branch October 8, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Android] Crash in audioapi::AudioScheduledSourceNode::clearOnEndedCallback()

4 participants