Feat: ConstantSourceNode #707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vltkv
reviewed
Oct 1, 2025
maciejmakowski2003
requested changes
Oct 1, 2025
michalsek
approved these changes
Oct 1, 2025
Member
michalsek
left a comment
michalsek
left a comment
There was a problem hiding this comment.
Besides existing comments LGTM, good job! convolver next :)
maciejmakowski2003
approved these changes
Oct 3, 2025
Collaborator
maciejmakowski2003
left a comment
maciejmakowski2003
left a comment
There was a problem hiding this comment.
great work. congrats for first core contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RNAA-264
Introduced changes
Implemented ConstantSourceNode
Checklist