Skip to content

Fix: correct param initialization on play in AudioBufferSource interactive playground #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maciejmakowski2003 merged 2 commits into from
Sep 18, 2025
Merged

Fix: correct param initialization on play in AudioBufferSource interactive playground #673

maciejmakowski2003 merged 2 commits into from
Sep 18, 2025

Conversation

@miloszwielgus
Copy link
Collaborator

@miloszwielgus miloszwielgus commented Sep 16, 2025

Closes

⚠️ Breaking changes ⚠️

Introduced changes

  • added correct param initialization when playing the sample in 'AudioBufferSourceExample' so it always starts with correct parameters chosen by the user

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web

@maciejmakowski2003 maciejmakowski2003 merged commit 2ea570a into software-mansion:main Sep 18, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maciejmakowski2003 maciejmakowski2003 maciejmakowski2003 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@miloszwielgus @maciejmakowski2003