Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inspect stack not returning all ancestors #693

Merged
merged 14 commits into from
Nov 22, 2024
Merged

Fix inspect stack not returning all ancestors #693

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c0e08fa
Fix inspect stack not returning all ancestors
km1chno Nov 4, 2024
9659390
Export inspector logic to lib/inspector.js
km1chno Nov 6, 2024
fc1cdb7
Merge branch 'main' into @km1chno/fix-inspector-stack
km1chno Nov 6, 2024
531a131
call measure parallely
km1chno Nov 6, 2024
09b2164
move require to method
km1chno Nov 6, 2024
c044aca
Merge branch 'main' into @km1chno/fix-inspector-stack
km1chno Nov 6, 2024
c0359f8
import getInspectorDataForCoordinates in InternalImports
km1chno Nov 6, 2024
35da5b2
stash
km1chno Nov 12, 2024
4f795c7
brought back the new logic to wrapper.js
km1chno Nov 12, 2024
bf28934
Merge branch 'main' into @km1chno/fix-inspector-stack
km1chno Nov 12, 2024
4169d18
Find renderer at the start of tree traversal
km1chno Nov 13, 2024
5870181
ignore elements without source before measure
km1chno Nov 13, 2024
4f1e5e6
Merge remote-tracking branch 'origin/main' into @km1chno/fix-inspecto…
kmagiera Nov 20, 2024
6e5b3e1
Some cleanup
kmagiera Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
import getInspectorDataForCoordinates in InternalImports
  • Loading branch information
@km1chno
km1chno committed Nov 6, 2024
commit c0359f84ac38726b835520369cb3dd562dc6b002
8 changes: 5 additions & 3 deletions packages/vscode-extension/lib/wrapper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ const {
View,
Linking,
} = require("react-native");
const { getInspectorDataForCoordinates } = require("./inspector");
const { storybookPreview } = require("./storybook_helper");

const navigationPlugins = [];
Expand All @@ -22,6 +21,9 @@ const InternalImports = {
get PREVIEW_APP_KEY() {
return require("./preview").PREVIEW_APP_KEY;
},
get getInspectorDataForCoordinates() {
return require("./inspector").getInspectorDataForCoordinates;
},
};

const RNInternals = {
Expand Down Expand Up @@ -176,8 +178,8 @@ export function AppWrapper({ children, initialProps, ..._rest }) {
"RNIDE_inspect",
(payload) => {
const { id, x, y, requestStack } = payload;

getInspectorDataForCoordinates(
InternalImports.getInspectorDataForCoordinates(
km1chno marked this conversation as resolved.
Show resolved Hide resolved
mainContainerRef,
x,
y,
Expand Down