Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct positioning of InspectDataMenu #639

Merged
merged 10 commits into from
Oct 18, 2024

Conversation

p-malecki
Copy link
Contributor

This PR includes improvements to the inspector menu:

  • hides inspector in the replay view
  • corrects the positioning of the InspectDataMenu, ensuring the DropdownMenu appears at the cursor location
  • adds label that displays the dimensions of the inspected element to the InspectDataMenu (similar to Show dimensions of inspected element #585)
  • adds a key prop to the components list in InspectDataMenu to prevent error messages

How Has This Been Tested:

  • open the replay view and attempt to use the inspector using right mouse button
  • close the replay view and confirm the inspector menu operates correctly
  • ensure that the inspector menu displays the components' dimensions at the top as expected
Screenshot 2024-10-18 at 19 26 18 Screenshot 2024-10-18 at 19 28 59

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radon-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 5:35pm

@p-malecki p-malecki merged commit 2e71cea into main Oct 18, 2024
3 checks passed
@p-malecki p-malecki deleted the @p-malecki/minor-inspector-fixes branch October 18, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants