Add buildScript option #504
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jakub-gonet
force-pushed
the
jgonet/prebuilt
branch
from
c3fa364
to
1d91137
Compare
| await buildProcess; | ||
|
|
||
| if (!apkPath || fs.existsSync(apkPath)) { | ||
| throw new Error("Build script didn't output any app path"); |
There was a problem hiding this comment.
I believe that dis error will cause webview to display buildErrorAlert, but this error alert is redirecting the user to build logs, which is not usefull in this case, could you make a special case for external builds that displays appropriate message and redirects to launchConfiguration?
jakub-gonet
force-pushed
the
jgonet/prebuilt
branch
from
7ec0514
to
06e349c
Compare
|
Build works correctly, app crashes when launched. Need to investigate. |
jakub-gonet
force-pushed
the
jgonet/prebuilt
branch
from
d4fe832
to
3c9d749
Compare
| ): Promise<string> { | ||
| const { stdout, lastLine: binaryPath } = await runExternalScript(cancelToken, externalCommand); | ||
|
|
||
| let easBinaryPath = await downloadAppFromEas(stdout, platform, cancelToken); |
There was a problem hiding this comment.
I understand this code is generic and not specific to EAS, why we use EAS in the method name then?
There was a problem hiding this comment.
It is specific to EAS, we assume certain JSON structure.
| const installApk = (allowDowngrade: boolean) => | ||
| exec( | ||
| ADB_PATH, | ||
| ["-s", this.serial!, "install", ...(allowDowngrade ? ["-d"] : []), "-r", build.apkPath], |
There was a problem hiding this comment.
any reason why we can't just always "allow downgrade" ??
There was a problem hiding this comment.
adb only allows downgrading debuggable packages. If we assume that every app we install is debuggable then we can always do it.
There was a problem hiding this comment.
that's a good point. I think it's ok to assume process is debuggable unless it's expo go
jakub-gonet
force-pushed
the
jgonet/prebuilt
branch
from
11e5395
to
e2642ab
Compare
jakub-gonet
force-pushed
the
jgonet/prebuilt
branch
from
07a99c4
to
d4a7c56
Compare
There was a problem hiding this comment.
I think we can merge it as is. Would be great to do a quick follow up to add better caching, specifically for the eas builds. Now every fingerprint change will result in us downloading the same EAS build while as long as build ID stays the same, there's no reason to download the file again
Adds new configuration options to launch config:
buildScript– replacing default build process with any script that outputs built app's path as last line of standard output (e.g. fetching app binary from the internet or using built app from local fs). It's an object withiosandandroidstring keys.eas– replacing default build process with fetching app from EAS build service. It's an object withprofile,useBuildType, andbuildUUIDkeys.profileis used to select correct build profile fromeas.json,useBuildTypeis either"latest"or"id"used to select either latest suitable build or selecting build via build UUID.buildUUIDis required when usinguseBuildType: "id".You can't specify both
easandbuildScriptfor one platform.Test plan
buildScript– simple"echo SOME_PATH"script for both platforms.eas– tested both platforms, for "latest" and "id" strategies.Followups
Resolves #150.