Merged
Conversation
Closed
GuzekAlan
reviewed
Oct 17, 2025
Contributor
GuzekAlan
left a comment
GuzekAlan
left a comment
There was a problem hiding this comment.
Since some of the code will change after the refactoring of traces I think it is ok. (only left some nitpicks). Works well. Good Job 🐬
hhubert6
reviewed
Oct 20, 2025
Contributor
hhubert6
left a comment
hhubert6
left a comment
There was a problem hiding this comment.
Looking good
Wondering if filter for seeing only diffs wouldn't be helpful.
Member
Author
Theoretically you can achieve that by filtering out every callback function. We can consider adding a button to form like "unselect all" - we'll be rethinking filters form anyway with the designer, so we can leave it for later cc @hhubert6 |
hhubert6
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I introduced a new trace associated with LiveView diffs that are sent to the browser from LiveView via WebSocket. They can be accessed via global traces view, after selecting corresponding option in the filters form
Traces as a structure needs some unification, but since this PR is already big, I decided to refactor it in the next PR
Screen.Recording.2025-10-16.at.12.14.19.mov