Skip to content

Feature: Add dead LiveViews section#798

Merged
hhubert6 merged 23 commits intomainfrom
764-add-dead-liveviews-section-to-discoverylive
Oct 23, 2025
Merged

Feature: Add dead LiveViews section#798
hhubert6 merged 23 commits intomainfrom
764-add-dead-liveviews-section-to-discoverylive

Conversation

@hhubert6
Copy link
Contributor

No description provided.

@hhubert6 hhubert6 linked an issue Oct 14, 2025 that may be closed by this pull request
@hhubert6 hhubert6 marked this pull request as ready for review October 15, 2025 10:12
Copy link
Contributor

@GuzekAlan GuzekAlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kraleppa
Copy link
Member

I'd also like to redesign it a bit - this is my proposition, but we can wait for the designs.

I'd change the title to Dead LiveViews

I wouldn't display Dead LiveViews at all with garbage collection enabled, since having LiveView displayed for 2s is not that helpful

I think that the warning text is too long in both variants and we should probably use component similar to our flash but implementation for warning. Maybe you could decrease number of text by moving some stuff to tooltip

Imo this color in warning is too gold(ish) - I'd change it to swm-yellow-80 or -60

From left to right: Dead LiveViews inactive variant, variant with Garbage collection on, variant with garbage collection off
LiveDebugger-1 0 0 drawio

@hhubert6
Copy link
Contributor Author

In terms pure UI I'd wait for the designs to not change it multiple times unnecessary.

If we want this to function as a full feature I'd strongly avoid situation in which the only option to access it is via disabling garbage collection. It might enhance the chance for someone to disable it and leave it which might cause memory related issues. In my point of view option to disable gc is for rare edge cases which we can't easily cover otherwise.
I'd say to maybe increase the time dead LiveView is displayed or explore other solutions rather than hiding whole feature after gc disabling.

cc @kraleppa

@hhubert6 hhubert6 requested a review from kraleppa October 21, 2025 08:50
@kraleppa
Copy link
Member

It might enhance the chance for someone to disable it and leave it which might cause memory related issues

I agree, but I'd probably try to increase the time dead LiveView is displayed - IMO current version where LiveViews are appearing and disappearing looks quite "buggy" - it gives a feeling that something is malfunctioning.

Also, since GC off is such undesirable state I'd rethink the banners with information about GC turned off and on that you created. I'd probably change the one which is displayed on GC off to info because this is not potentially dangerous situation, and thanks to that banner displayed on GC on will be more prominent

cc @hhubert6

@hhubert6
Copy link
Contributor Author

I'd probably change the one which is displayed on GC off to info because this is not potentially dangerous situation, and thanks to that banner displayed on GC on will be more prominent

I'm a little confused. Shouldn't on "GC off" be as a warning (increased memory usage) and on "GC on" as a info that user can disable it?

cc @kraleppa

@kraleppa
Copy link
Member

@hhubert6

I'm a little confused. Shouldn't on "GC off" be as a warning (increased memory usage) and on "GC on" as a info that user can disable it?

That's what I meant - sorry 😅

@hhubert6 hhubert6 merged commit 5a64c2e into main Oct 23, 2025
2 checks passed
@hhubert6 hhubert6 deleted the 764-add-dead-liveviews-section-to-discoverylive branch October 23, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "Dead LiveViews" section to DiscoveryLive

4 participants