Explicit formats in SocketDiscoveryController#754
Merged
srzeszut merged 1 commit intosoftware-mansion:mainfrom Sep 18, 2025
Merged
Explicit formats in SocketDiscoveryController#754srzeszut merged 1 commit intosoftware-mansion:mainfrom
srzeszut merged 1 commit intosoftware-mansion:mainfrom
Conversation
Fixes compilation warning.
Before:
```
==> live_debugger
Compiling 127 files (.ex)
warning: use LiveDebugger.App.Controllers.SocketDiscoveryController must receive the :formats option with the formats you intend to render. To keep compatibility within your app, you can list it as:
formats: [html: "View", json: "View", ...]
Listing all formats your application renders.
```
After: no warning.
---
The controller only does a redirect, it never renders any format, so the empty list should be suitable for now.
srzeszut
approved these changes
Sep 18, 2025
Contributor
|
Thanks for your contribution! |
srzeszut
pushed a commit
that referenced
this pull request
Oct 9, 2025
Fixes compilation warning.
Before:
```
==> live_debugger
Compiling 127 files (.ex)
warning: use LiveDebugger.App.Controllers.SocketDiscoveryController must receive the :formats option with the formats you intend to render. To keep compatibility within your app, you can list it as:
formats: [html: "View", json: "View", ...]
Listing all formats your application renders.
```
After: no warning.
---
The controller only does a redirect, it never renders any format, so the empty list should be suitable for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes compilation warning.
Before:
After: no warning.
The controller only does a redirect, it never renders any format, so the empty list should be suitable for now.