Skip to content

Bug: Fix appearance buttons in settings are not synchronized across tabs#736

Merged
srzeszut merged 8 commits intomainfrom
721-appearance-buttons-in-settings-are-not-synchronized-across-tabs
Sep 11, 2025
Merged

Bug: Fix appearance buttons in settings are not synchronized across tabs#736
srzeszut merged 8 commits intomainfrom
721-appearance-buttons-in-settings-are-not-synchronized-across-tabs

Conversation

@srzeszut
Copy link
Contributor

@srzeszut srzeszut commented Sep 9, 2025

No description provided.

@srzeszut srzeszut linked an issue Sep 9, 2025 that may be closed by this pull request
@srzeszut srzeszut marked this pull request as ready for review September 9, 2025 16:50
@srzeszut srzeszut force-pushed the 721-appearance-buttons-in-settings-are-not-synchronized-across-tabs branch from be81a08 to 5439608 Compare September 10, 2025 08:46
Copy link
Contributor

@hhubert6 hhubert6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

as I think of this it would be great to have e2e test for settings syncing across tabs (theme buttons and other switches)

srzeszut and others added 3 commits September 10, 2025 12:48
Co-authored-by: Hubert Kasprzycki <67634024+hhubert6@users.noreply.github.com>
@srzeszut srzeszut requested a review from hhubert6 September 10, 2025 13:24
@srzeszut srzeszut requested a review from hhubert6 September 11, 2025 10:27
@srzeszut srzeszut merged commit dc72a87 into main Sep 11, 2025
2 checks passed
srzeszut added a commit that referenced this pull request Oct 9, 2025
…abs (#736)

* fix changing themes across tabs

* Move toggle theme logic to app.js
srzeszut added a commit that referenced this pull request Oct 9, 2025
@kraleppa kraleppa deleted the 721-appearance-buttons-in-settings-are-not-synchronized-across-tabs branch February 3, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Appearance buttons in settings are not synchronized across tabs

3 participants