Skip to content

Bug: Highlighting LiveViews in LiveComponents#725

Merged
GuzekAlan merged 6 commits intomainfrom
716-highlighting-nested-liveview-inside-livecomponent
Sep 18, 2025
Merged

Bug: Highlighting LiveViews in LiveComponents#725
GuzekAlan merged 6 commits intomainfrom
716-highlighting-nested-liveview-inside-livecomponent

Conversation

@GuzekAlan
Copy link
Contributor

No description provided.

@GuzekAlan GuzekAlan linked an issue Sep 1, 2025 that may be closed by this pull request
@GuzekAlan GuzekAlan requested a review from kraleppa September 1, 2025 10:26
Copy link
Member

@kraleppa kraleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an e2e test for it - we already have tests for inspection in LiveDebugger.E2E.ElementsInspectionTest

Copy link
Contributor

@hhubert6 hhubert6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@GuzekAlan GuzekAlan force-pushed the 716-highlighting-nested-liveview-inside-livecomponent branch from b5d2bc0 to dfb24a1 Compare September 17, 2025 12:28
@GuzekAlan GuzekAlan force-pushed the 716-highlighting-nested-liveview-inside-livecomponent branch from dfb24a1 to eeaeca7 Compare September 17, 2025 12:30
@GuzekAlan GuzekAlan requested a review from hhubert6 September 17, 2025 12:39
Copy link
Contributor

@hhubert6 hhubert6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling that when someone enters debugger view with the wrong node_id as shown in #716 we should redirect rather then show those error messages but it can be done in another pr.

@GuzekAlan GuzekAlan merged commit 604a791 into main Sep 18, 2025
2 checks passed
@GuzekAlan GuzekAlan deleted the 716-highlighting-nested-liveview-inside-livecomponent branch September 18, 2025 07:00
GuzekAlan added a commit that referenced this pull request Oct 9, 2025
* add example for bug

* fix url on inspecting

* fix naming problem in dev

* Add test
GuzekAlan added a commit that referenced this pull request Oct 9, 2025
* Bug: Highlighting LiveViews in LiveComponents (#725)

* build assets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Highlighting Nested LiveView inside LiveComponent

3 participants