Bug: fix highlighting on dead view mode#694
Merged
Conversation
kraleppa
reviewed
Aug 22, 2025
Member
kraleppa
left a comment
kraleppa
left a comment
There was a problem hiding this comment.
Is there a chance to create test for this?
GuzekAlan
force-pushed
the
681-bug-highlighting-in-deadviewmode-crashes
branch
from
c9aa184 to
caf8918
Compare
Contributor
Author
|
Not sure if we want to do it but I can also disable cc @kraleppa |
Member
|
@GuzekAlan please do it - I think it is a bit misleading when you can inspect dead LiveView |
kraleppa
approved these changes
Aug 25, 2025
GuzekAlan
force-pushed
the
681-bug-highlighting-in-deadviewmode-crashes
branch
from
d69ab42 to
1845869
Compare
GuzekAlan
added a commit
that referenced
this pull request
Aug 25, 2025
* disable highlight on entering dead view mode * add handle_info fallback * add dead_view_mode e2e test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.