Merged
Conversation
GuzekAlan
reviewed
Aug 11, 2025
lib/live_debugger_refactor/app/debugger/callback_tracing/web/hooks/display_new_traces.ex
Outdated
Show resolved
Hide resolved
lib/live_debugger_refactor/app/debugger/callback_tracing/web/hooks/display_new_traces.ex
Show resolved
Hide resolved
lib/live_debugger_refactor/app/debugger/callback_tracing/web/hooks/display_new_traces.ex
Outdated
Show resolved
Hide resolved
kraleppa
approved these changes
Aug 12, 2025
Member
kraleppa
left a comment
kraleppa
left a comment
There was a problem hiding this comment.
Nice idea with using debounce!
GuzekAlan
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to mitigate this unpleasant effect when filtering by execution time. When callback takes at least a few hundred milliseconds after call trace is displayed with timer and then is removed if filter does not match. However when callback is quick (something around under 10ms) it sometimes is not displayed at all and sometimes it shows for a split second. With many callbacks running traces blinks which randomly. I tried to resolve this with some debouncing.