Skip to content

Refactor: better structure in assets#638

Merged
kraleppa merged 9 commits intomainfrom
assets-refactor
Jul 31, 2025
Merged

Refactor: better structure in assets#638
kraleppa merged 9 commits intomainfrom
assets-refactor

Conversation

@kraleppa
Copy link
Member

No description provided.

@kraleppa kraleppa requested review from GuzekAlan and hhubert6 July 30, 2025 08:06
Copy link
Contributor

@hhubert6 hhubert6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this changes mix setup must also be updated to install node dependencies correctly. For example:

setup: [
  "deps.get",
  "cmd --cd assets/app npm install",
  "cmd --cd assets/client npm install",
  "assets.setup",
  "assets.build:dev"
],

Copy link
Contributor

@GuzekAlan GuzekAlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌🏽

@kraleppa kraleppa requested a review from hhubert6 July 30, 2025 10:51
Copy link
Contributor

@hhubert6 hhubert6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@kraleppa kraleppa merged commit d585bf9 into main Jul 31, 2025
2 checks passed
@kraleppa kraleppa deleted the assets-refactor branch July 31, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants