Skip to content

Refactor: Create actions and queries for settings context#626

Merged
hhubert6 merged 8 commits intomainfrom
625-create-actions-for-livedebuggerrefactorappsettings
Jul 29, 2025
Merged

Refactor: Create actions and queries for settings context#626
hhubert6 merged 8 commits intomainfrom
625-create-actions-for-livedebuggerrefactorappsettings

Conversation

@hhubert6
Copy link
Contributor

No description provided.

@hhubert6 hhubert6 requested review from GuzekAlan and kraleppa July 28, 2025 12:08
@hhubert6 hhubert6 linked an issue Jul 28, 2025 that may be closed by this pull request
@hhubert6 hhubert6 marked this pull request as draft July 28, 2025 14:20
@hhubert6 hhubert6 changed the title Refactor: Create actions for settings context Refactor: Create actions and queries for settings context Jul 28, 2025
Copy link
Contributor

@GuzekAlan GuzekAlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Have you checked if UserRefreshedTrace event is properly handled and works ?

@hhubert6 hhubert6 linked an issue Jul 28, 2025 that may be closed by this pull request
@hhubert6
Copy link
Contributor Author

Looks good. Have you checked if UserRefreshedTrace event is properly handled and works ?

Yes, it is.

@hhubert6 hhubert6 marked this pull request as ready for review July 28, 2025 14:35
@hhubert6 hhubert6 requested a review from GuzekAlan July 28, 2025 14:35
Copy link
Contributor

@GuzekAlan GuzekAlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hhubert6 hhubert6 force-pushed the 625-create-actions-for-livedebuggerrefactorappsettings branch from 0c9d70f to d406440 Compare July 29, 2025 08:56
@hhubert6 hhubert6 requested review from GuzekAlan and kraleppa July 29, 2025 09:07
Copy link
Contributor

@GuzekAlan GuzekAlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@hhubert6 hhubert6 merged commit 498f6b6 into main Jul 29, 2025
2 checks passed
@hhubert6 hhubert6 deleted the 625-create-actions-for-livedebuggerrefactorappsettings branch July 29, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prepare data loading for settings context Create actions for LiveDebuggerRefactor.App.Settings

3 participants