Skip to content

Refactor: Create node_state context (part I)#621

Merged
hhubert6 merged 7 commits intomainfrom
595-create-node_state-context
Jul 28, 2025
Merged

Refactor: Create node_state context (part I)#621
hhubert6 merged 7 commits intomainfrom
595-create-node_state-context

Conversation

@hhubert6
Copy link
Contributor

I will add TreeNode struct to TermParser for better typing in components attributes and tests for TermParser in the next PR as this one is already pretty long.

@hhubert6 hhubert6 requested review from GuzekAlan and kraleppa July 24, 2025 11:45
@hhubert6 hhubert6 linked an issue Jul 24, 2025 that may be closed by this pull request
Copy link
Member

@kraleppa kraleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks fine but I'd like to clarify what's the reason for moving wrapper for live_render to NodeState.Web module

@GuzekAlan
Copy link
Contributor

Overall it looks fine but I'd like to clarify what's the reason for moving wrapper for live_render to NodeState.Web module

Since these are contexts and live_render is function used by other context it is a way of accessing this context (Simillar to how Phoenix contexts work on backend side where you expose functions to manage resources of one context). It basically is a nice way to expose functions to render elements form other context

@hhubert6 hhubert6 force-pushed the 595-create-node_state-context branch from 16e99f1 to a7406fa Compare July 25, 2025 14:44
@hhubert6 hhubert6 requested review from GuzekAlan and kraleppa July 25, 2025 14:45
@hhubert6 hhubert6 merged commit 256ffad into main Jul 28, 2025
2 checks passed
@hhubert6 hhubert6 deleted the 595-create-node_state-context branch July 28, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create node_state context

3 participants