Merged
Conversation
hhubert6
reviewed
Jul 11, 2025
Contributor
hhubert6
left a comment
hhubert6
left a comment
There was a problem hiding this comment.
Tests for Bus and Event have files names that do not end with _test.exs. Because of that they don't run when running mix test and on CI (I don't know if that was done intentionally?). Tests for Bus fail due to changes in this PR.
hhubert6
approved these changes
Jul 14, 2025
samrobinsonsauce
pushed a commit
to samrobinsonsauce/live-debugger
that referenced
this pull request
Jul 18, 2025
* LiveDebugger initialization depending on flag * Added services supervisors * Added README to callback tracer * Added garbage collector README * Added description for ProcessMonitor * Added readme for state manager * Changed names of tests * Fixed tests * Not starting services in case of unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.