Skip to content

Feature: Add search bar to global traces#570

Merged
kraleppa merged 11 commits intosoftware-mansion:mainfrom
samrobinsonsauce:485-add-search-bar-to-global-traces
Jul 21, 2025
Merged

Feature: Add search bar to global traces#570
kraleppa merged 11 commits intosoftware-mansion:mainfrom
samrobinsonsauce:485-add-search-bar-to-global-traces

Conversation

@samrobinsonsauce
Copy link
Contributor

Info

resolves: #485

Adds a search bar to the global traces view.
This allows the user to filter the list of traces via a search query.

Screenshot 2025-07-07 at 20 07 20

@samrobinsonsauce samrobinsonsauce force-pushed the 485-add-search-bar-to-global-traces branch 2 times, most recently from 251391a to 9beb106 Compare July 7, 2025 20:49
@samrobinsonsauce samrobinsonsauce marked this pull request as ready for review July 7, 2025 20:52
@kraleppa kraleppa changed the title 485 add search bar to global traces Feature: Add search bar to global traces Jul 8, 2025
@kraleppa kraleppa self-requested a review July 8, 2025 06:37
Copy link
Member

@kraleppa kraleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome! We actually have a figma with the designs for this feature, but I'm not sure if I can share it with you. For now I will send you screenshots and could you please style this input to match them?

Also, could you create a test for it? We usually write them using wallaby - check test/live_debugger/process_callback_traces_test.exs

Screenshots
Screenshot 2025-07-08 at 09 36 04
Screenshot 2025-07-08 at 09 35 51

@samrobinsonsauce samrobinsonsauce force-pushed the 485-add-search-bar-to-global-traces branch from 3154ae9 to 955bc4e Compare July 8, 2025 21:13
@kraleppa
Copy link
Member

kraleppa commented Jul 9, 2025

There’s one more thing to address: if a user has started callback tracing, we should prevent any modifications to the search phrase.

If the user entered a search phrase before starting the tracing, that phrase should be used to filter the incoming traces, but it cannot be modified

A simple way to handle this would be to disable the search input once tracing has started.

@kraleppa
Copy link
Member

I spot a weird bug - it seems like search is working only before I start tracing. See the video below

Screen.Recording.2025-07-14.at.09.31.58.mov

Also, I find it a bit confusing that after you type in something to search box and start tracing you can receive traces that do not match provided serach phrase...

lvdbg.mov

IMO, it can be handled in two ways

  1. We leave search box as it is, but we have to filter incoming trace by search phrase either.
  2. When user starts tracing we hide checkbox entirely and clear the search phrase.

I think the first option is a bit more intresting

@samrobinsonsauce
Copy link
Contributor Author

I spot a weird bug - it seems like search is working only before I start tracing. See the video below

Screen.Recording.2025-07-14.at.09.31.58.mov
Also, I find it a bit confusing that after you type in something to search box and start tracing you can receive traces that do not match provided serach phrase...

lvdbg.mov
IMO, it can be handled in two ways

  1. We leave search box as it is, but we have to filter incoming trace by search phrase either.
  2. When user starts tracing we hide checkbox entirely and clear the search phrase.

I think the first option is a bit more intresting

Hey @kraleppa,

yeah the last commit only handles disabling the search input when tracing is active the next one. I too had noticed the strange behaviour with the search only working before activating tracing and i had planned to fix it in the next commit!

I also agree that if the user has searched something, we should filter the incoming traces so that we only render those that match the search phrase.

I'll look to fix these issues soon, progress has been a little slow as i broke my leg last week 😂

@kraleppa
Copy link
Member

@samrobinsonsauce great - thanks for the update and get well!

@samrobinsonsauce samrobinsonsauce force-pushed the 485-add-search-bar-to-global-traces branch from b31ec10 to cc31a88 Compare July 18, 2025 19:48
@samrobinsonsauce samrobinsonsauce force-pushed the 485-add-search-bar-to-global-traces branch from cc31a88 to cf81bb8 Compare July 18, 2025 19:50
@samrobinsonsauce samrobinsonsauce force-pushed the 485-add-search-bar-to-global-traces branch from fb302bb to 2ada47d Compare July 18, 2025 20:26
@samrobinsonsauce
Copy link
Contributor Author

samrobinsonsauce commented Jul 18, 2025

@kraleppa Implemented the filtering of incoming traces based on the search phrase as well as an e2e test to exercise it. Any feedback lemme know 👌

Copy link
Member

@kraleppa kraleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the above comment it looks good. Great job! 🚀

@samrobinsonsauce
Copy link
Contributor Author

Besides the above comment it looks good. Great job! 🚀

Thanks @kraleppa!

That feedback should be sorted now 👌

@kraleppa kraleppa merged commit efa40e8 into software-mansion:main Jul 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add search bar to global callback traces

2 participants