Conversation
Closed
GuzekAlan
reviewed
Jul 7, 2025
Contributor
GuzekAlan
left a comment
GuzekAlan
left a comment
There was a problem hiding this comment.
Nice 👍
Can you add test for it (I mean create simple event like in docs and assert it just to be sure that it generates good struct.
Do we want to have LiveDebuggerRefactor module in our app and then after refactor change it? It shouldn't be a problem with changing it in the end but wanted to confirm so that we would stick to it? We can add Readme for this folder saying that these are refactored files and it will in the end be main app
Member
Author
I'd say yes - I want to make sure that module names won't overlap with current implementation and to make a bigger distinction between those implementations |
GuzekAlan
approved these changes
Jul 8, 2025
samrobinsonsauce
pushed a commit
to samrobinsonsauce/live-debugger
that referenced
this pull request
Jul 18, 2025
* Added event module * Added better docs * Added docs * Added event type * Added README to live_debugger_refactor * Added basic tests * Fixed credo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.