consolidate sidebar children#506
Merged
kraleppa merged 6 commits intosoftware-mansion:mainfrom Jun 24, 2025
Merged
Conversation
hhubert6
reviewed
Jun 16, 2025
Contributor
hhubert6
left a comment
hhubert6
left a comment
There was a problem hiding this comment.
Looks good, but it definitely needs to be incorporated into sidebar_slide_over so that it could be reusable.
Contributor
Author
|
Thanks @hhubert6, i've updated the Let me know what you think 😄 |
kraleppa
approved these changes
Jun 24, 2025
Member
kraleppa
left a comment
kraleppa
left a comment
There was a problem hiding this comment.
awesome - thanks for contribution!
GuzekAlan
approved these changes
Jun 24, 2025
hhubert6
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for #495.
Renders a single
<.sidebar_content>component rather than duplicates which helps retain form state when we transition to a mobile view.