Skip to content

Enhancement: applied new designs to filters form#488

Merged
kraleppa merged 17 commits intomainfrom
441-update-callback-traces-filters-designs
Jun 10, 2025
Merged

Enhancement: applied new designs to filters form#488
kraleppa merged 17 commits intomainfrom
441-update-callback-traces-filters-designs

Conversation

@kraleppa
Copy link
Member

@kraleppa kraleppa commented Jun 6, 2025

No description provided.

@kraleppa kraleppa requested review from GuzekAlan and hhubert6 June 6, 2025 14:05
@kraleppa kraleppa linked an issue Jun 6, 2025 that may be closed by this pull request
@kraleppa kraleppa requested a review from GuzekAlan June 9, 2025 15:42
Copy link
Contributor

@GuzekAlan GuzekAlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that changing filters and exiting fullscreen saves them (but don't update). It is misleading UX. We should always show current filters when opening filters in fullscreen

Copy link
Contributor

@GuzekAlan GuzekAlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🦈
We should rethink our approach to fullscreen and potentially change it to LiveComponent but it can be done after 0.3

@kraleppa kraleppa merged commit bdcf67b into main Jun 10, 2025
2 checks passed
@kraleppa kraleppa deleted the 441-update-callback-traces-filters-designs branch June 10, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update callback traces filters to new designs

2 participants