Refactor: extracted logic and components from traces_live#466
Refactor: extracted logic and components from traces_live#466
traces_live#466Conversation
GuzekAlan
left a comment
There was a problem hiding this comment.
Overall I like the composition style. Making component_hook is nice. It could even be a behaviour.
It has some coupling and one init function is dependant on other which makes you call modules in correct order. Also there are some assigns which are dependant one on another. It is better than it was since now we have sections separated and checks if we've added them correctly but still it is a little messy. I feel like some structs for frontend might help (to aggregate e.g. existing_traces, existing_traces_status, traces_continuation, traces_empty?) but it is outside of this scope. As I said grat job breaking Traces into smaller pieces 🎉
I'm aware of it and the logic separation is definitely not ideal, there are a lot of assigns that are shared between components, and as you mentioned some components are dependent on each other. I'd take a closer look at this "context" maybe after release and think if it could be improved even better, because currently it's:
|
No description provided.