Skip to content

Refactor: extracted logic and components from traces_live#466

Merged
kraleppa merged 38 commits intomainfrom
feature/global-traces-view
Jun 4, 2025
Merged

Refactor: extracted logic and components from traces_live#466
kraleppa merged 38 commits intomainfrom
feature/global-traces-view

Conversation

@kraleppa
Copy link
Member

@kraleppa kraleppa commented Jun 3, 2025

No description provided.

@kraleppa kraleppa requested review from GuzekAlan and hhubert6 June 3, 2025 12:27
@kraleppa kraleppa marked this pull request as ready for review June 3, 2025 12:27
Copy link
Contributor

@GuzekAlan GuzekAlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like the composition style. Making component_hook is nice. It could even be a behaviour.

It has some coupling and one init function is dependant on other which makes you call modules in correct order. Also there are some assigns which are dependant one on another. It is better than it was since now we have sections separated and checks if we've added them correctly but still it is a little messy. I feel like some structs for frontend might help (to aggregate e.g. existing_traces, existing_traces_status, traces_continuation, traces_empty?) but it is outside of this scope. As I said grat job breaking Traces into smaller pieces 🎉

@kraleppa
Copy link
Member Author

kraleppa commented Jun 4, 2025

It has some coupling and one init function is dependant on other which makes you call modules in correct order. Also there are some assigns which are dependant one on another. It is better than it was since now we have sections separated and checks if we've added them correctly but still it is a little messy.

I'm aware of it and the logic separation is definitely not ideal, there are a lot of assigns that are shared between components, and as you mentioned some components are dependent on each other. I'd take a closer look at this "context" maybe after release and think if it could be improved even better, because currently it's:

  • the biggest LiveView in our app
  • the most complex one
  • the most important one

@kraleppa kraleppa requested a review from GuzekAlan June 4, 2025 07:26
@kraleppa kraleppa linked an issue Jun 4, 2025 that may be closed by this pull request
Copy link
Contributor

@GuzekAlan GuzekAlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🦈

@kraleppa kraleppa merged commit d377d66 into main Jun 4, 2025
2 checks passed
@kraleppa kraleppa deleted the feature/global-traces-view branch June 4, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename channel_dashboard to node_inspector

2 participants