Skip to content

Refactor: Udpate to lucide icons#456

Merged
GuzekAlan merged 18 commits intomainfrom
424-update-icons-to-lucide
Jun 5, 2025
Merged

Refactor: Udpate to lucide icons#456
GuzekAlan merged 18 commits intomainfrom
424-update-icons-to-lucide

Conversation

@GuzekAlan
Copy link
Contributor

No description provided.

@GuzekAlan GuzekAlan linked an issue Jun 2, 2025 that may be closed by this pull request
@GuzekAlan GuzekAlan marked this pull request as ready for review June 2, 2025 11:23
@GuzekAlan GuzekAlan requested review from hhubert6 and kraleppa and removed request for kraleppa June 2, 2025 11:23
@kraleppa
Copy link
Member

kraleppa commented Jun 2, 2025

My impression is that some of the icons are in lower resolution and I can see pixels. It may be because stroke-width is to small

Check refresh icon here
Screenshot 2025-06-02 at 15 42 37

Square icons here
Screenshot 2025-06-02 at 15 42 49

Info icon here
Screenshot 2025-05-29 at 15 49 56

@GuzekAlan
Copy link
Contributor Author

@kraleppa I've checked and even with strike-width=2 it does look a little pixeled
image
image

It looks better but still not perfect. I have this issue when displaying on external monitor. Maybe there is some issue with rendering svgs in general.

Currently on main there is still pixeled refresh.
image

I'll try to adjust sizes to the icons because they feel larger now and on strike-width-2 since it might look better

Copy link
Contributor

@hhubert6 hhubert6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GuzekAlan GuzekAlan merged commit 6f6d331 into main Jun 5, 2025
2 checks passed
@GuzekAlan GuzekAlan deleted the 424-update-icons-to-lucide branch June 5, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update icons to Lucide

3 participants