feat: Introduce Index buffers and improve buffer UX #1340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pkg.pr.new packages benchmark commit |
reczkok
force-pushed
the
feat/index-buffers
branch
from
c9c3e0a to
ce93b12
Compare
Also update resolveData to throw for u16 type in WGSL. Remove unused test buffer in cubemap-reflection example.
- Add a simple square example with color controls - Implement .withIndexBuffer and .drawIndexed for render pipelines - Allow u16 arrays as index buffers; improve type safety for buffer schemas - Update alignment and size maps to include u16 - Refactor HasNestedType utility and enforce buffer schema constraints
reczkok
force-pushed
the
feat/index-buffers
branch
from
ce93b12 to
741e69d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
iwoplaza
requested changes
Jun 18, 2025
iwoplaza
requested changes
Jun 18, 2025
iwoplaza
approved these changes
Jun 23, 2025
Comment on lines
+541
to
+543
| const pass = this.setupRenderPass(); | ||
| const { branch } = this[$internal].core.options; | ||
| const internals = this[$internal]; |
There was a problem hiding this comment.
Small suggestion
Suggested change
| const pass = this.setupRenderPass(); | |
| const { branch } = this[$internal].core.options; | |
| const internals = this[$internal]; | |
| const internals = this[$internal]; | |
| const pass = this.setupRenderPass(); | |
| const { branch } = internals.core.options; |
mhawryluk
reviewed
Jun 24, 2025
| color: readonly [number, number, number], | ||
| position: keyof typeof colors, | ||
| ): void { | ||
| colors[position] = d.vec4f(color[0], color[1], color[2], 1); |
There was a problem hiding this comment.
Suggested change
| colors[position] = d.vec4f(color[0], color[1], color[2], 1); | |
| colors[position] = d.vec4f(...color, 1); |
aleksanderkatan
approved these changes
Jun 24, 2025
| @@ -357,6 +362,17 @@ export interface RenderPass { | |||
| ): undefined; | |||
| } | |||
|
|
|||
| type ValidateSchema<TData extends AnyData> = HasNestedType< | |||
There was a problem hiding this comment.
What was our consensus on returning errors in types? Are we going to keep doing this or is this a special case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a very simple square example that uses the experimental APIs and demonstrates the index buffer :)
closes #863