Fix native ActivityIndicator not being shown on Android #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfeiffer
reviewed
Nov 6, 2023
Comment on lines
+203
to
+214
| override fun requestLayout() { | ||
| super.requestLayout() | ||
| post(measureAndLayout) | ||
| } | ||
|
|
||
| private val measureAndLayout = Runnable { | ||
| measure( | ||
| MeasureSpec.makeMeasureSpec(width, MeasureSpec.EXACTLY), | ||
| MeasureSpec.makeMeasureSpec(height, MeasureSpec.EXACTLY) | ||
| ) | ||
| layout(left, top, right, bottom) | ||
| } |
There was a problem hiding this comment.
Would it make sense to add a comment describing why this code has been added?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android native progressView/ActivityIndicator was not visible when opening slow loading page. It was caused by react-native behavior: to achieve performance, not all native components are being re-laid. Also manually re-laying the progressView in
onLayoutdidin't work as expected. A fix from here solved this issue.