added <pre> tag to table data to preserve new lines

[dhoomakethu]

I needed this features as my JSON had values with multiline string , with

 the newlines could be preserved and will be presented with better formatting.

[softvar]

Tests have failed and I think it's not necessary.

Can you please add the screenshots, before and after the change? Would help a lot.

[muellermichel]

I think in general the pre-tag may make sense, however this is the wrong way to do it IMO. With this implementation everything within a td, including sub tables, sub lists, sub objects, gets wrapped in a <pre>. This could lead to lots of unwanted behaviour. Instead IMO it should be done on line 112 in markup, just for unicode elements.

[dhoomakethu]

Oops, I raised the PR by mistake ,apologies for that.I was in a bit of hurry, so did not modified the tests, , I will update them as well. Just for the sake of clarification , here is the issue and how the pre tag solves the formatting.

Without "pre" tag

With "pre" tag

I agree with @muellermichel 's comment ,this is a fast cooked solution solving my current problem, I probably shouldn't have had the PR raised , I will decline the PR .

----update----
Looks like I do not have rights to decline my own PR , @softvar please decline.

Thank you.

---update2-----
My bad, something wrong with my eyes :P , closing this.

[softvar]

Please don't feel offended. Take your time. I really appreciate the patch.
Would love to see it getting merged soon :)
On May 27, 2016 8:33 AM, "dhoomakethu" notifications@github.com wrote:

Closed #19 #19.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#19 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AD_LQHqo7dNweSTF4-qp4f6-Xb6GB4pTks5qFl78gaJpZM4InUm_
.