Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated #273

Closed
wants to merge 2 commits into from
Closed

Conversation

sameer0583
Copy link

No description provided.

@JiPaix
Copy link

JiPaix commented Nov 5, 2022

this would close #268, #264, #265, #263, #250, #249.

@rix1337
Copy link

rix1337 commented Nov 6, 2022

For those of you looking for an up2date alternative, just go and use https://github.com/ncipollo/release-action

@koplo199
Copy link
Contributor

koplo199 commented Nov 7, 2022

You need to regenerate the package-lock.json file and the dist directory, as is this PR won't do anything. It can't even pass the CI.

@koplo199
Copy link
Contributor

koplo199 commented Nov 7, 2022

I've done it (among other things) in #275.

@sameer0583
Copy link
Author

sameer0583 commented Nov 7, 2022

You need to regenerate the package-lock.json file and the dist directory, as is this PR won't do anything. It can't even pass the CI.

Yea, you need to do what is in https://github.com/softprops/action-gh-release/blob/master/.github/workflows/main.yml

However, that action in itself is broken as it should run npm install before. Those changes are not pertinent to the actual fixes this addresses and is more a general fix
image

This should also use v3 of checkout

@sameer0583
Copy link
Author

I was able to regenerate all the files in my forked repo, use it in another workflow with no dependency issues

@koplo199
Copy link
Contributor

koplo199 commented Nov 7, 2022

However, that action in itself is broken as it should run npm install before.

Yes the action is broken because you broke it by not regenerating the package-lock.json. npm ci works differently than npm install, and the latter is not mandatory given a valid package.json/package-lock.json duo.

This should also use v3 of checkout

Irrelevant to the issue, but yes.

@softprops
Copy link
Owner

hi folks this should be fixed now with #275

@softprops softprops closed this Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants