Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pick one body #145

Merged
merged 1 commit into from
Sep 11, 2021
Merged

pick one body #145

merged 1 commit into from
Sep 11, 2021

Conversation

softprops
Copy link
Owner

@softprops softprops commented Aug 10, 2021

when building a body, don't repeat content that might already exist.

@0x90d
Copy link

0x90d commented Aug 30, 2021

@softprops Is there a reason why you don't have merged it yet?

@softprops
Copy link
Owner Author

I wanted to make sure I'd given it test run. first would you be able to give this a spin before merging to master.

would you be able to give this a spin. you should be able to reference it by branch pick-one-body

@0x90d
Copy link

0x90d commented Sep 8, 2021

@softprops Sorry for the late reply, I didn't get any notification although I've subscribed. How can I reference to this branch, do I need to change my workflow line from: uses: softprops/action-gh-release@v1 to uses: softprops/action-gh-release@pick-one-body ?

@softprops
Copy link
Owner Author

softprops commented Sep 8, 2021

that's correct

@0x90d
Copy link

0x90d commented Sep 11, 2021

@softprops I've tested it and it works fine

@softprops
Copy link
Owner Author

thanks for testing! Ill merge and release the changes this weekend. Ill post back here for visibility

@softprops softprops merged commit a3f0173 into master Sep 11, 2021
@softprops softprops deleted the pick-one-body branch September 11, 2021 03:07
@softprops
Copy link
Owner Author

changes should but pushed to v1 tag now

@abcfy2
Copy link
Contributor

abcfy2 commented Sep 22, 2021

But how to repeat? I need this feature for matrix build and output for different build info.

@softprops
Copy link
Owner Author

I think we're going to need a customization input flag for that. I'd like for defaults to work for the common cases if there's demand we can add a hook for customization

@abcfy2
Copy link
Contributor

abcfy2 commented Nov 22, 2021

I think we're going to need a customization input flag for that. I'd like for defaults to work for the common cases if there's demand we can add a hook for customization

Any update ? Thanks.

@abcfy2 abcfy2 mentioned this pull request Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants