Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new release is created if name is omited #363

Open
vgcpge opened this issue Jun 8, 2023 · 0 comments
Open

A new release is created if name is omited #363

vgcpge opened this issue Jun 8, 2023 · 0 comments

Comments

@vgcpge
Copy link

vgcpge commented Jun 8, 2023

README states:

When the release info keys (such as name, body, draft, prerelease, etc.) are not explicitly set and there is already an existing release for the tag, the release will retain its original info.

name is documented as explicitly optional for release update. However, if a release is created using tag_name and a different name, and then an update to release is done using tag_name, while omitting name, a new release is created instead of the intended update.
The documentation implies that tag_name is the primary key that distinguishes releases, but the actual action uses name as a primary key.

I'm not sure what is the intended behavior here, but the documentation should probably be consistent with actual behavior.

Example of the update behavior:
Release creation: https://github.com/vgcpge/eclipse.copilot/actions/runs/5214840618/jobs/9411641411 (Create Github release section)
An attempt to update the release by uploading an artifact: https://github.com/vgcpge/eclipse.copilot/actions/runs/5214840618/jobs/9411660424 (Upload release artifact section)

vgcpge added a commit to vgcpge/eclipse.copilot that referenced this issue Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant