[Upgrade] Move to NSs, autoloading with PSR-4 and dependency management #10
Conversation
phansys
force-pushed
the
composer
branch
4 times, most recently
from
3e00f4e to
450a68d
Compare
|
Thanks for the PR! Looking at this. |
|
Thank you @underscorephil. Please let me know if you have any doubt or comment about these changes. |
| @@ -92,7 +86,7 @@ class Softlayer_XmlrpcClient | |||
| * | |||
| * @var string | |||
| */ | |||
| const API_BASE_URL = SoftLayer_XmlrpcClient::API_PUBLIC_ENDPOINT; | |||
| const API_BASE_URL = XmlRpcClient::API_PUBLIC_ENDPOINT; | |||
There was a problem hiding this comment.
Should this be self:: here instead of XmlRpcClinet::?
|
@phansys ready to merge after I get your response on the line note |
| Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | yes | Deprecations? | no | Tests pass? | | Fixed tickets | softlayer#8 | License | MIT | Doc PR | Fixes softlayer#8. * Moved class names to namespaces respecting [PSR-4](http://www.php-fig.org/psr/psr-4/) autoload standard. * Added [Composer](https://getcomposer.org/) as dependency manager In order to allow this library to be installed with Composer, it must be submitted in [Packagist](https://packagist.org/packages/submit) after this PR is merged.
|
Sorry for the delay @underscorephil. PR updated and rebased. Thank you. |
[Upgrade] Move to NSs, autoloading with PSR-4 and dependency management
|
Nice to find this library in Packagist! Ping @underscorephil. |
Fixes #8.
autoload standard.
In order to allow this library to be installed with Composer, it must be submitted
in Packagist after this PR is merged.