Add warning for build-in function map #25
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warn user about returning map obj in 3.x
| .mypy_cache/ | ||
| .pytest_cache/ | ||
| .DS_Store | ||
| .history/ |
Lib/test/test_builtin.py
Outdated
| with warnings.catch_warnings(record=True) as w: | ||
| warnings.simplefilter("always") | ||
| list(map(lambda x: x, [1, 2, 3])) | ||
| self.assertTrue(any("returns map object in 3.x" in |
There was a problem hiding this comment.
This message doesn't match what is in the warning
There was a problem hiding this comment.
Move to test_2x_warnings file and use with check_py2x_warnings() as w: because again the -2 flag has to be used for these warnings to be triggered.
There was a problem hiding this comment.
@nanjekyejoannah fixed and moved, thanks for pointing out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified map_vectorcall in bltinmodule.c, which warn user about behavior change of map in 3.x (return map object)
Add a test case in test_builtin.py