Warn for bytes/str parsing methods#38
Merged
ltratt merged 4 commits intosoftdevteam:regression_fixfrom Apr 9, 2024
Merged
Conversation
Member
|
Looks like a good start to me! |
Member
That looks like a test that checks the size of a struct? Seems a bit odd to me, so we could consider disabling it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More thinking got me to think maybe we dont need to separate the objects.
@ltratt you are right,
""in py2.x is very close to""in py3.x: I concluded from thisquerying the difference in methods at least by parsing:
When I get to runtime warning we can do with the states for the most part without separation.
This PR replaces the former and will do the warnings in several PRs instead of one huge one.